[PATCH v2 1/1] shell32: Partially implement IShellItemImageFactory (icon only, no thumbnail).

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them if they are indeed new. Note that rare
failures and failures with always changing text (e.g. because of memory
addresses) can cause false positives. If this is what happened, then
fixing those would really help.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=117022

Your paranoid android.


=== w1064v1809 (32 bit report) ===

shell32:
shlfolder.c:4959: Test failed: CREATE: expected notification type 2, got: 40000
shlfolder.c:4966: Test failed: GetDisplayNameOf failed: 0x80070057
shlfolder.c:4976: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 2)

=== w1064 (32 bit report) ===

shell32:
shlfolder.c:4959: Test failed: CREATE: expected notification type 2, got: 40000
shlfolder.c:4966: Test failed: GetDisplayNameOf failed: 0x80070057
shlfolder.c:4976: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 2)

=== w1064_tsign (32 bit report) ===

shell32:
shlfolder.c:4959: Test failed: CREATE: expected notification type 2, got: 40000
shlfolder.c:4966: Test failed: GetDisplayNameOf failed: 0x80070057
shlfolder.c:4976: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 2)

=== w1064v1809 (64 bit report) ===

shell32:
shlfolder.c:4976: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 3)

=== w1064 (64 bit report) ===

shell32:
shlfolder.c:4976: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 3)

=== w1064_2qxl (64 bit report) ===

shell32:
shlfolder.c:4976: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 3)

=== w1064_adm (64 bit report) ===

shell32:
shlfolder.c:4976: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 40000)

=== w1064_tsign (64 bit report) ===

shell32:
shlfolder.c:4959: Test failed: CREATE: expected notification type 2, got: 40000
shlfolder.c:4966: Test failed: GetDisplayNameOf failed: 0x80070057
shlfolder.c:4976: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 2)

=== w10pro64_en_AE_u8 (64 bit report) ===

shell32:
shlfolder.c:4976: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 3)
shlfolder.c:4976: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 3)
shlfolder.c:4976: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 3)
shlfolder.c:4976: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 3)
shlfolder.c:4976: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 3)
shlfolder.c:4959: Test failed: RMDIR: expected notification type 10, got: 40000
shlfolder.c:4966: Test failed: GetDisplayNameOf failed: 0x80070057
shlfolder.c:4976: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 3)

=== w10pro64_ar (64 bit report) ===

shell32:
shlfolder.c:4976: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 2)
shlfolder.c:4959: Test failed: RMDIR: expected notification type 10, got: 40000
shlfolder.c:4966: Test failed: GetDisplayNameOf failed: 0x80070057
shlfolder.c:4976: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 10)
shlfolder.c:4976: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 3)
shlfolder.c:4976: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 3)
shlfolder.c:4976: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 3)

=== w10pro64_ja (64 bit report) ===

shell32:
shlfolder.c:4959: Test failed: RMDIR: expected notification type 10, got: 40000
shlfolder.c:4966: Test failed: GetDisplayNameOf failed: 0x80070057
shlfolder.c:4976: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 10)
shlfolder.c:4976: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 3)
shlfolder.c:4976: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 3)
shlfolder.c:4976: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 3)
shlfolder.c:4976: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 3)
shlfolder.c:4959: Test failed: CREATE: expected notification type 2, got: 40000
shlfolder.c:4966: Test failed: GetDisplayNameOf failed: 0x80070057
shlfolder.c:4976: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 3)

=== w10pro64_zh_CN (64 bit report) ===

shell32:
shlfolder.c:4976: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 3)