Gitlab experiment wrapup

[Alexandre Julliard]

Huw Davies <huw at codeweavers.com> writes:

> On Tue, Jun 14, 2022 at 10:01:23PM +0200, Alexandre Julliard wrote:
>> Another option would be to require the submitter to explicitly approve
>> their own MR if it contains a patch written by someone else; that would
>> be similar to a reviewer pushing fixups and then approving the MR.  It
>> would require some mechanism to detect missing approvals though, so it
>> may not be worth the trouble.
>
> Could the (yet to be written) auto-add-reviewer script check whether
> the submitter and author are different and in that case auto add the
> submitter as a reviewer (as well as any other appropriate reviewers)?
> Then the approval check just becomes the same as for regular
> reviewers.

Yes, that would be a way of doing it, if we decide that we want that
info in the git notes. Do you feel that it would be useful to have it
there?

-- 
Alexandre Julliard
julliard at winehq.org