[PATCH v2 0/1] MR252: shell32/tests: Add tests for Program Manager name sanitization.

Alex Henrie (@alexhenrie) wine at gitlab.winehq.org
Fri Jun 17 00:56:17 CDT 2022


I benchmarked it today and on my laptop, the new tests raised the test time from 5 seconds to 2 minutes 15 seconds. I can see how that would be a problem.

I've now pared the tests back to the bare minimum set of tests that I believe are necessary to demonstrate that my proposed solution in merge request !23 solves the problem. Paring back the tests dropped the test time to 36 seconds, mainly because the check_window_exists tests are now skipped if check_exists has already failed. (check_window_exists is very fast if the window does exist, but it will spend a long time waiting for a window that never appears.)

Would it be acceptable to start by committing this set of tests, and build on it later as needed?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/252#note_2243



More information about the wine-devel mailing list