[tools] testbot/LogUtils: Make the compilation error detection stricter.

Francois Gouget fgouget at codeweavers.com
Fri Jun 17 09:49:44 CDT 2022


This avoids some false positives in the d3d WINE_ERR() messages.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
Specifically this type of messages in the Wine log which are simple 
WINE_ERR() messages and should thus be ignored by the TestBot:
059c:err:d3d:wined3d_debug_callback 0016A650: "0:43(1): error: error index must be >= 0".
059c:fixme:d3d_shader:print_glsl_info_log     0:43(1): error: error index must be >= 0
---
 testbot/lib/WineTestBot/LogUtils.pm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/testbot/lib/WineTestBot/LogUtils.pm b/testbot/lib/WineTestBot/LogUtils.pm
index 4c643b9e09..9e73b5f63d 100644
--- a/testbot/lib/WineTestBot/LogUtils.pm
+++ b/testbot/lib/WineTestBot/LogUtils.pm
@@ -102,7 +102,10 @@ sub GetLogLineCategory($)
       $Line =~ /^error: patch failed:/ or
       $Line =~ /^error: corrupt patch / or
       # Build errors
-      $Line =~ /: error: / or
+      # Note that just ': error:' leads to false positives. So assume the
+      # error location (source filename + line number) contains no space.
+      $Line =~ /^[^ ]+: fatal error: / or # nonexistent include file
+      $Line =~ /^[^ ]+: error: / or
       $Line =~ /: undefined reference to `/ or
       $Line =~ /^make: [*]{3} No rule to make target / or
       $Line =~ /^Makefile:\d+: recipe for target .* failed$/ or
-- 
2.30.2



More information about the wine-devel mailing list