[tools] testbot: Fix the default Failures sort order.

Francois Gouget fgouget at codeweavers.com
Fri Jun 17 09:52:45 CDT 2022


Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
Initially the last criterion was the failure id but then I decided 
sorting by the bug description made more sense. Unfortunately I forgot 
to switch the comparison from integers to strings.
---
 testbot/lib/WineTestBot/Failures.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testbot/lib/WineTestBot/Failures.pm b/testbot/lib/WineTestBot/Failures.pm
index f0f78b6ff7..906205119c 100644
--- a/testbot/lib/WineTestBot/Failures.pm
+++ b/testbot/lib/WineTestBot/Failures.pm
@@ -53,7 +53,7 @@ sub Compare($$)
   my $Cmp = ($StatusOrders{$self->GetColValue("BugStatus")} || 0) <=> ($StatusOrders{$B->GetColValue("BugStatus")} || 0) ||
          $self->GetColValue("ErrorGroup") cmp $B->GetColValue("ErrorGroup") ||
          $self->GetColValue("TestUnit") cmp $B->GetColValue("TestUnit") ||
-         $self->GetColValue("BugDescription") <=> $B->GetColValue("BugDescription");
+         $self->GetColValue("BugDescription") cmp $B->GetColValue("BugDescription");
   return $Cmp
 }
 
-- 
2.30.2




More information about the wine-devel mailing list