[tools 2/2] patches: Add an end tag for some <td colspan='xxx'>.

Francois Gouget fgouget at codeweavers.com
Fri Jun 17 09:58:53 CDT 2022


Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
I saw no indication that <td ... /> is valid but the Mozilla
documentation says:
| The end tag may be omitted, if it is immediately followed by a <th>
| or <td> element or if there are no more data in its parent element.
Overall it just seems better to have an end tag.
---
 patches/update | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/patches/update b/patches/update
index f3eac9eeac..8f79da9c4a 100755
--- a/patches/update
+++ b/patches/update
@@ -338,15 +338,15 @@ foreach my $file (sort { $patches{$b}->{"order"} <=> $patches{$a}->{"order"} } k
     if (@signoff)
     {
         printf INDEX "<tr class=\"%s $file.signoff\" id=\"$file.signoff\" style=\"display: none;\" onclick=\"toggle_display('$file.signoff')\">" .
-                     "<td colspan=\"5\" /><td colspan=\"4\" class=\"signoffextra author\">%s</td></tr>\n",
+                     "<td colspan=\"5\"></td><td colspan=\"4\" class=\"signoffextra author\">%s</td></tr>\n",
                $row & 1 ? "odd" : "even", join("", map { "Signed-off-by: " . escapeHTML($_) . "<br/>"; } @signoff );
     }
     foreach my $child (@{$patch->{"children"}})
     {
         printf INDEX "<tr class=\"%s\ $file.reply\" id=\"%s\" style=\"display: none;\" onclick=\"toggle_display('$file.reply')\">" .
-                     "<td colspan=\"2\" /><td colspan=\"2\" class=\"reply author\"><span class=\"indent\">%s</span></td> " .
+                     "<td colspan=\"2\"></td><td colspan=\"2\" class=\"reply author\"><span class=\"indent\">%s</span></td> " .
                      "<td class=\"reply author\"><span class=\"indent\"><a href=\"data/%s\">%s</a></span></td> " .
-                     "<td colspan=\"4\" /></tr>\n",
+                     "<td colspan=\"4\"></td></tr>\n",
             $row & 1 ? "odd" : "even", $child->{"id"}, escapeHTML($child->{"author"}), $child->{"id"}, escapeHTML($child->{"subject"});
     }
     $row++;
-- 
2.30.2



More information about the wine-devel mailing list