[PATCH v3 1/6] comctl32/tests: Expand ownerdata listview tests.

[Zhiyi Zhang]

On 6/20/22 05:51, Angelo Haller wrote:
> On 18/06/2022 21.34, Zhiyi Zhang wrote:
>>
>> On 6/19/22 01:24, Angelo Haller wrote:
>>> On 17/06/2022 22.37, Marvin wrote:
>>>> Hi,
>>>>
>>>> It looks like your patch introduced the new failures shown below.
>>>> Please investigate and fix them before resubmitting your patch.
>>>> If they are not new, fixing them anyway would help a lot. Otherwise
>>>> please ask for the known failures list to be updated.
>>>>
>>>> The full results can be found at:
>>>> https://testbot.winehq.org/JobDetails.pl?Key=117220
>>>>
>>>> Your paranoid android.
>>>>
>>>>
>>>> === debian11 (32 bit report) ===
>>>>
>>>> Report validation errors:
>>>> comctl32:listview prints too much data (37148 bytes)
>>>>
>>>> === debian11 (32 bit Arabic:Morocco report) ===
>>>>
>>>> Report validation errors:
>>>> comctl32:listview prints too much data (37148 bytes)
>>>>
>>>> === debian11 (32 bit German report) ===
>>>>
>>>> Report validation errors:
>>>> comctl32:listview prints too much data (37148 bytes)
>>>>
>>>> === debian11 (32 bit French report) ===
>>>>
>>>> Report validation errors:
>>>> comctl32:listview prints too much data (37148 bytes)
>>>>
>>>> === debian11 (32 bit Hebrew:Israel report) ===
>>>>
>>>> Report validation errors:
>>>> comctl32:listview prints too much data (37148 bytes)
>>>>
>>>> === debian11 (32 bit Hindi:India report) ===
>>>>
>>>> Report validation errors:
>>>> comctl32:listview prints too much data (37148 bytes)
>>>>
>>>> === debian11 (32 bit Japanese:Japan report) ===
>>>>
>>>> Report validation errors:
>>>> comctl32:listview prints too much data (37148 bytes)
>>>>
>>>> === debian11 (32 bit Chinese:China report) ===
>>>>
>>>> Report validation errors:
>>>> comctl32:listview prints too much data (37148 bytes)
>>>>
>>>> === debian11 (32 bit WoW report) ===
>>>>
>>>> Report validation errors:
>>>> comctl32:listview prints too much data (37148 bytes)
>>>>
>>>> === debian11 (64 bit WoW report) ===
>>>>
>>>> Report validation errors:
>>>> comctl32:listview prints too much data (37388 bytes)
>>> Is there anything I can or need to do about this? These seem like false positives.
>>>
>>>
>> Currently TestBots have a 32k log size limit. Try to reduce the log messages a bit. You can submit your tests at https://testbot.winehq.org/ before submitting to the wine-devel mailing list
>
> I see. How can I reduce log messages though? Short of removing tests?
>
> As can be seen in the series, the test do start to succeed as of patch 5/6. So the failure is only introduced due to wine_todo sequences being logged to the terminal. I am not generating any additional log messages.
>

In this case, you can move the tests into the same patch or after the patch that fixes the bug.