[PATCH v5 1/1] ws2_32: Allow getsockname after AcceptEx.
David Curtiss
wine at gitlab.winehq.org
Mon Jun 20 16:56:11 CDT 2022
From: David Curtiss <david.curtiss at ni.com>
.NET 6's HTTP/Socket code queries this. Winsock allows getsockname
on the AcceptEx AcceptSocket, but only if SO_UPDATE_ACCEPT_CONTEXT
is set.
Signed-off-by: David Curtiss <david.curtiss at ni.com>
---
dlls/ws2_32/tests/sock.c | 9 +++++++++
server/sock.c | 1 +
2 files changed, 10 insertions(+)
diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c
index af4226e6258..3ec0ab67040 100644
--- a/dlls/ws2_32/tests/sock.c
+++ b/dlls/ws2_32/tests/sock.c
@@ -8143,6 +8143,15 @@ static void test_AcceptEx(void)
ok(bret, "GetOverlappedResult failed, error %ld\n", GetLastError());
ok(bytesReturned == 0, "bytesReturned isn't supposed to be %ld\n", bytesReturned);
+ /* Try to call getsockname on the acceptor socket.
+ *
+ * On Windows, this requires setting SO_UPDATE_ACCEPT_CONTEXT. */
+ iret = setsockopt(acceptor, SOL_SOCKET, SO_UPDATE_ACCEPT_CONTEXT, (char *)&listener, sizeof(SOCKET));
+ ok(!iret, "Failed to set accept context %ld\n", GetLastError());
+ iret = getsockname(acceptor, (struct sockaddr *)&peerAddress, &remoteSize);
+ ok(!iret, "getsockname failed.\n");
+ ok(remoteSize == sizeof(struct sockaddr_in), "got remote size %u\n", remoteSize);
+
closesocket(connector);
connector = INVALID_SOCKET;
closesocket(acceptor);
diff --git a/server/sock.c b/server/sock.c
index b11ebddb51d..2f1b33a333d 100644
--- a/server/sock.c
+++ b/server/sock.c
@@ -1846,6 +1846,7 @@ static int accept_into_socket( struct sock *sock, struct sock *acceptsock )
}
acceptsock->state = SOCK_CONNECTED;
+ acceptsock->bound = 1;
acceptsock->pending_events = 0;
acceptsock->reported_events = 0;
acceptsock->proto = sock->proto;
--
GitLab
https://gitlab.winehq.org/wine/wine/-/merge_requests/192
More information about the wine-devel
mailing list