[PATCH v3 0/9] MR272: d3dx10: Add D3DX10CreateThreadPump implementation.

Matteo Bruni (@Mystral) wine at gitlab.winehq.org
Tue Jun 21 03:01:58 CDT 2022


Matteo Bruni (@Mystral) commented about dlls/d3dx10_43/d3dx10_43_main.c:
>      thread_pump_GetQueueStatus
>  };
>  
> +static DWORD WINAPI io_thread(void *arg)
> +{
> +    struct thread_pump *thread_pump = arg;
> +    struct work_item *work_item;
> +    UINT zero = 0;
> +    HRESULT hr;
> +
> +    TRACE("%p thread started.\n", thread_pump);
> +
> +    while (1)
> +    {
> +        RtlWaitOnAddress((void *)&thread_pump->io_count, &zero, sizeof(zero), NULL);
Nitpick, we prefer "for (;;)" for infinite loops.

You can drop these casts in RtlWaitOnAddress() calls too, I think.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/272#note_2438



More information about the wine-devel mailing list