[PATCH 0/1] MR296: nsiproxy.sys: Add static ARP entries which are always present on Windows.
Huw Davies (@huw)
wine at gitlab.winehq.org
Thu Jun 23 01:27:43 CDT 2022
Huw Davies (@huw) commented about dlls/iphlpapi/tests/iphlpapi.c:
>
> static void testGetIpNetTable(void)
> {
> - DWORD apiReturn;
> + const DWORD static_addr1 = 0x160000e0, static_addr2 = 0xfaffffef;
Could you use a macro or something to generate these from decimal? Also please use more meaningful variable names based on the addresses' uses (see https://en.wikipedia.org/wiki/Multicast_address#Notable_IPv4_multicast_addresses)
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/296#note_2523
More information about the wine-devel
mailing list