[tools] testbot: Sort failures on their notes as a last resort.

Francois Gouget fgouget at codeweavers.com
Fri Jun 24 09:25:29 CDT 2022


Sometimes a bug is spread across multiple failures and the Notes field
normally describes what each one corresponds to. Sorting on the Notes
field as a last resort typically ensures that all the parts are in an
order that makes sense.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
 testbot/lib/WineTestBot/Failures.pm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/testbot/lib/WineTestBot/Failures.pm b/testbot/lib/WineTestBot/Failures.pm
index 21b1610ca9..4a65374988 100644
--- a/testbot/lib/WineTestBot/Failures.pm
+++ b/testbot/lib/WineTestBot/Failures.pm
@@ -50,11 +50,11 @@ sub Compare($$)
   # Sort deleted entries last
   my %StatusOrders = ("deleted" => 1);
 
-  my $Cmp = ($StatusOrders{$self->GetColValue("BugStatus")} || 0) <=> ($StatusOrders{$B->GetColValue("BugStatus")} || 0) ||
+  return ($StatusOrders{$self->GetColValue("BugStatus")} || 0) <=> ($StatusOrders{$B->GetColValue("BugStatus")} || 0) ||
          $self->GetColValue("ErrorGroup") cmp $B->GetColValue("ErrorGroup") ||
          $self->GetColValue("TestUnit") cmp $B->GetColValue("TestUnit") ||
-         $self->GetColValue("BugDescription") cmp $B->GetColValue("BugDescription");
-  return $Cmp
+         $self->GetColValue("BugDescription") cmp $B->GetColValue("BugDescription") ||
+         $self->GetColValue("Notes") cmp $B->GetColValue("Notes");
 }
 
 sub BugId($;$)
-- 
2.30.2




More information about the wine-devel mailing list