[PATCH v2 0/3] MR310: mf: Fix several reference leaks.
Rémi Bernon (@rbernon)
wine at gitlab.winehq.org
Mon Jun 27 02:57:50 CDT 2022
On Mon Jun 27 07:52:49 2022 +0000, Nikolay Sivov wrote:
> This is already done in video_renderer_initialize(). Maybe it's not
> triggered on shutdown?
I think the test failure may come from a missing the `video_renderer_release_presenter_services` call, though I haven't really investigated that aspect of the problem. If it's the case, perhaps it should be added to `video_renderer_initialize` too.
The issue with the testbot and 32bit apps is that the way `Initialize` is currently written it create a second video renderer before releasing the previously created one. This requires another d3d device initialization, which often fails from address space exhaustion, so releasing the previous renderer first was resolving the issue (and the reference leak also probably made it worse).
More information about the wine-devel