[PATCH 0/3] MR330: Tests for properties.
Nikolay Sivov (@nsivov)
wine at gitlab.winehq.org
Tue Jun 28 02:57:21 CDT 2022
Nikolay Sivov (@nsivov) commented about dlls/d2d1/tests/d2d1.c:
> }
> effect_tests[] =
> {
> - {&CLSID_D2D12DAffineTransform, 1, 1, 1, 1},
> - {&CLSID_D2D13DPerspectiveTransform, 1, 1, 1, 1},
> - {&CLSID_D2D1Composite, 1, 2, 1, 0xffffffff},
> - {&CLSID_D2D1Crop, 1, 1, 1, 1},
> - {&CLSID_D2D1Shadow, 1, 1, 1, 1},
> - {&CLSID_D2D1Grayscale, 3, 1, 1, 1},
> + {&CLSID_D2D12DAffineTransform, 1, 4, 1, 1, 1},
> + {&CLSID_D2D13DPerspectiveTransform, 1, 8, 1, 1, 1},
> + {&CLSID_D2D1Composite, 1, 1, 2, 1, 0xffffffff},
> + {&CLSID_D2D1Crop, 1, 2, 1, 1, 1},
> + {&CLSID_D2D1Shadow, 1, 3, 1, 1, 1},
> + {&CLSID_D2D1Grayscale, 3, 0, 1, 1, 1},
> + };
I don't think it's very convenient to test a bunch of builtin effects at once. We won't have them implemented at the same time, so that will require more skips/todos. It's better to have that tested in per-effect functions, like test_effect_2d_affine().
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/330#note_2848
More information about the wine-devel
mailing list