[PATCH 0/3] MR330: Tests for properties.

Nikolay Sivov (@nsivov) wine at gitlab.winehq.org
Tue Jun 28 02:59:08 CDT 2022


Nikolay Sivov (@nsivov) commented about dlls/d2d1/tests/d2d1.c:
> +        const WCHAR *name;
> +        D2D1_PROPERTY_TYPE type;
> +        UINT32 value_size;
> +    }
> +    property_tests[] =
> +    {
> +        {D2D1_PROPERTY_CLSID,       L"CLSID",       D2D1_PROPERTY_TYPE_CLSID,  sizeof(CLSID)},
> +        {D2D1_PROPERTY_DISPLAYNAME, L"DisplayName", D2D1_PROPERTY_TYPE_STRING, 0},
> +        {D2D1_PROPERTY_AUTHOR,      L"Author",      D2D1_PROPERTY_TYPE_STRING, 0},
> +        {D2D1_PROPERTY_CATEGORY,    L"Category",    D2D1_PROPERTY_TYPE_STRING, 0},
> +        {D2D1_PROPERTY_DESCRIPTION, L"Description", D2D1_PROPERTY_TYPE_STRING, 0},
> +        {D2D1_PROPERTY_INPUTS,      L"Inputs",      D2D1_PROPERTY_TYPE_ARRAY,  sizeof(UINT32)},
> +        {D2D1_PROPERTY_CACHED,      L"Cached",      D2D1_PROPERTY_TYPE_BOOL,   sizeof(UINT32)},
> +        {D2D1_PROPERTY_PRECISION,   L"Precision",   D2D1_PROPERTY_TYPE_ENUM,   sizeof(UINT32)},
> +        {D2D1_PROPERTY_MIN_INPUTS,  L"MinInputs",   D2D1_PROPERTY_TYPE_UINT32, sizeof(UINT32)},
> +        {D2D1_PROPERTY_MAX_INPUTS,  L"MaxInputs",   D2D1_PROPERTY_TYPE_UINT32, sizeof(UINT32)},
I believe this is a set of system properties that are always available, even if not specified explicitly. That includes custom effects. Maybe additional helper to test such predefined properties is better, we can use it for custom effect tests and in each builtin effect test function.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/330#note_2849



More information about the wine-devel mailing list