[PATCH 0/1] MR331: winecfg: Support color profiles larger than MAX_PATH chars.

Zhiyi Zhang (@zhiyi) wine at gitlab.winehq.org
Tue Jun 28 07:27:04 CDT 2022


Zhiyi Zhang (@zhiyi) commented about programs/winecfg/theme.c:
>  static void do_parse_theme(WCHAR *file)
>  {
> -    WCHAR keyName[MAX_PATH], keyNameValue[MAX_PATH];
> +    WCHAR *keyName, keyNameValue[MAX_PATH];
> +    DWORD len, allocLen = 512;
>      WCHAR *keyNamePtr = NULL;
>      int red = 0, green = 0, blue = 0;
>      COLORREF color;
>  
> -    WINE_TRACE("%s\n", wine_dbgstr_w(file));
> +    keyName = malloc(sizeof(*keyName) * allocLen);
> +    for (;;)
> +    {
> +        assert(keyName);
> +        len = GetPrivateProfileStringW(L"Control Panel\\Colors", NULL, NULL, keyName,
> +                                allocLen, file);
Formatting.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/331#note_2853



More information about the wine-devel mailing list