[PATCH 0/1] MR338: mmdevapi: Override product strings for DualSense controller audio devices
Andrew Eikum (@aeikum)
wine at gitlab.winehq.org
Wed Jun 29 08:40:33 CDT 2022
Andrew Eikum (@aeikum) commented about dlls/mmdevapi/devenum.c:
> if (!RegCreateKeyExW(key, L"Properties", 0, NULL, 0, KEY_WRITE|KEY_READ|KEY_WOW64_64KEY, NULL, &keyprop, NULL))
> {
> PROPVARIANT pv;
> + pv.pwszVal = NULL;
> +
> + if (SUCCEEDED(drvs.pGetPropValue(id, &devicepath_key, &pv))) {
> + MMDevice_SetPropValue(id, flow, &devicepath_key, &pv);
> +
> + /* Some applications expect a specific name for the DualSense audio device */
> + pv.pwszVal = find_device_string(pv.pwszVal);
This comment shouldn't be specific to DualSense controllers, and I think you could even remove the comment entirely if you rename the function.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/338#note_2952
More information about the wine-devel
mailing list