[PATCH 0/1] MR338: mmdevapi: Override product strings for DualSense controller audio devices

Andrew Eikum (@aeikum) wine at gitlab.winehq.org
Wed Jun 29 08:40:34 CDT 2022


Andrew Eikum (@aeikum) commented about dlls/mmdevapi/devenum.c:
>          if (!RegCreateKeyExW(key, L"Properties", 0, NULL, 0, KEY_WRITE|KEY_READ|KEY_WOW64_64KEY, NULL, &keyprop, NULL))
>          {
>              PROPVARIANT pv;
> +            pv.pwszVal = NULL;
> +
> +            if (SUCCEEDED(drvs.pGetPropValue(id, &devicepath_key, &pv))) {
Not all drivers implement GetPropValue, so you can't unconditionally call it. `set_driver_prop_value` could maybe use a refactor so this doesn't get messy.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/338#note_2953



More information about the wine-devel mailing list