[PATCH v2 0/4] MR322: winex11.drv: Preparation for nulldrv display modes.

Zhiyi Zhang (@zhiyi) wine at gitlab.winehq.org
Thu Jun 30 02:19:21 CDT 2022


Zhiyi Zhang (@zhiyi) commented about dlls/winex11.drv/desktop.c:
> +}
> +
> +/* retrieve the default desktop size from the registry */
> +static BOOL get_default_desktop_size( unsigned int *width, unsigned int *height )
> +{
> +    static const WCHAR desktop_keyW[] = {'S','o','f','t','w','a','r','e','\\','W','i','n','e','\\',
> +                                         'E','x','p','l','o','r','e','r','\\',
> +                                         'D','e','s','k','t','o','p','s',0};
> +    static const WCHAR defaultW[] = {'D','e','f','a','u','l','t',0};
> +    WCHAR buffer[4096];
> +    KEY_VALUE_PARTIAL_INFORMATION *value = (void *)buffer;
> +    DWORD size;
> +    HKEY hkey;
> +
> +    *width = 800;
> +    *height = 600;
screen_width and screen_height will be set to max_width and max_height should this function fails. so these two lines seem redundant.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/322#note_2997



More information about the wine-devel mailing list