[tools] testbot/cgi: Remove the Cancel action from collection pages.

Francois Gouget fgouget at codeweavers.com
Wed Mar 2 09:59:53 CST 2022


What this action would do is not defined, it has not been implemented
and there does not seem to be a need for it.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
 testbot/lib/ObjectModel/CGI/CollectionBlock.pm | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/testbot/lib/ObjectModel/CGI/CollectionBlock.pm b/testbot/lib/ObjectModel/CGI/CollectionBlock.pm
index 058bb47846..effd039fb2 100644
--- a/testbot/lib/ObjectModel/CGI/CollectionBlock.pm
+++ b/testbot/lib/ObjectModel/CGI/CollectionBlock.pm
@@ -391,11 +391,6 @@ sub GetActions($)
   {
     $Actions[0] = "Add " . $self->{Collection}->GetItemName();
   }
-  my ($MasterColNames, $MasterColValues) = $self->{Collection}->GetMasterCols();
-  if (defined($MasterColNames))
-  {
-    push @Actions, "Cancel";
-  }
 
   return \@Actions;
 }
@@ -506,11 +501,7 @@ sub OnAction($$)
 {
   my ($self, $Action) = @_;
 
-  if ($Action eq "Cancel")
-  {
-    # FIXME Todo
-  }
-  elsif ($Action eq "Add " . $self->{Collection}->GetItemName())
+  if ($Action eq "Add " . $self->{Collection}->GetItemName())
   {
     my $Target = $self->CallGetDetailsPage();
     my ($MasterColNames, $MasterColValues) = $self->{Collection}->GetMasterCols();
-- 
2.30.2




More information about the wine-devel mailing list