[PATCH 2/3] winegstreamer: Introduce new wg_transform_(push|read)_data functions.

[Zebediah Figura]

On 3/3/22 05:09, Rémi Bernon wrote:
> On 3/3/22 02:17, Zebediah Figura (she/her) wrote:
>> On 2/28/22 10:27, Rémi Bernon wrote:
>>> And use it to implement WMA decoder Process(Input|Output).
>>> -    todo_wine
>>> -    ok(i == 0xe000, "ProcessOutput produced %#x bytes\n", i);
>>> +    if (!strcmp(winetest_platform, "wine"))
>>> +        ok(i == 0x10000, "ProcessOutput produced %#x bytes\n", i);
>>> +    else
>>> +        ok(i == 0xe000, "ProcessOutput produced %#x bytes\n", i);
>>
>> This doesn't hold for me:
>>
>> 042c:fixme:wmadec:transform_GetInputAvailableType iface
>> 00000000008225A8, id 0, index 0, type 000000000021F7D0 stub!
>> 042c:fixme:mfplat:mf_media_type_to_wg_format_wma Bitrate is not set.
>> mf.c:6307: Test failed: ProcessOutput produced 0xc000 bytes
> 
> Hmm... weird, maybe some ffmpeg variation?
> 
> The testbot seems happy with it, though as it differs from native 
> already maybe I should simply make the check todo if it fails, or remove 
> it altogether.

I don't know what's responsible for the difference, but I don't think 
there's any reason to expect GStreamer or ffmpeg to be stable in the 
first place.

Personally I suspect we don't want to be that strict in the tests, 
unless applications really are going to depend on it.

Granted, it's one of those cases where it's probably not going to be 
easy to debug if an application does depend on it, but it's also rather 
difficult to fix Wine to match.