[PATCH v2 2/5] windows.media.speech: Move SpeechSynthesizer into sperate file.

[Bernhard Kölbl]

Am So., 6. März 2022 um 21:30 Uhr schrieb Rémi Bernon <rbernon at codeweavers.com>:

> As discussed elsewhere, this should return the HRESULT on success only,
> and handle the error case differently to return the appropriate error.

Yes, as discussed elsewhere I'll change this back to only call AddRef
instead of QueryInterface like your implementation in
Windows.Gaming.Input.

> Note that if you reorder your patches to rewrite DllGetClassObject
> first, as you're then requesting the HSTRING buffer pointer, you could
> then drop the debugstr_hstring helper.
>
> It's alright to keep it if you need it for something else later (though
> maybe best to drop it now and add it back later), but you can still
> simply call debugstr_w with the buffer pointer here.

Yes, the helper will be reused later quite a lot, but I could drop it for now.

Bernhard

> --
> Rémi Bernon <rbernon at codeweavers.com>
>