[PATCH vkd3d 3/5] tests: Use angle brackets instead of square brackets to separate shader test sections.
Zebediah Figura
zfigura at codeweavers.com
Mon Mar 7 10:47:51 CST 2022
On 3/7/22 05:40, Henri Verbeet wrote:
> On Mon, 7 Mar 2022 at 03:05, Zebediah Figura <zfigura at codeweavers.com> wrote:
>>
>> Unfortunately, square brackets are used in HLSL for attributes, and are usually
>> written on a line by themselves.
>>
>> Angle brackets are used in HLSL as delimiters as well, but usually are not
>> placed on a line by themselves.
>>
>> Signed-off-by: Zebediah Figura <zfigura at codeweavers.com>
>> ---
>> This was the most appealing option for a section delimiter, but I'm open to
>> others.
>>
> The traditional way to do this kind of thing is a
> here-document/here-string construction. Is that something we've
> considered?
Not per se, although I'm not sure it's an improvement. Here-strings are
kind of more inconvenient to type, and get away with it in the general
case because they're kind of rare, but we'll have at least one per file.
Perhaps more saliently, I'd like to be able to easily visually parse
sections (especially since we won't have anything like syntax
highlighting to help us), which implies at least that the test header
should be dissimilar to HLSL attributes.
More information about the wine-devel
mailing list