[PATCH 01/20] dlls/kernel32/tests/heap.c: enable compilation with long types

Francois Gouget fgouget at codeweavers.com
Tue Mar 8 13:23:20 CST 2022


On Tue, 8 Mar 2022, Eric Pouech wrote:
[...]
> (eg looking at what I've sent this morning: except the 3 patches for
> user32/tests (which are currently bound [*]), all the other ones could have
> been sent as a single mail)

I wouldn't want you to compromise reviewability for the TestBot though.

Also there's a 99 step limit per job which currently translates to 
something like a maximum of 48 patched test units (one step for 32-bit 
one for 64-bit). So craming too many test unit patches in a single email 
would be an issue.

Increasing the limit would be pretty easy. But each step corresponds to 
11 tasks so even with the current config that would be a ~1000 tasks 
job!


> if there are niceness issues, another option is to send less patches every day
> (I tried to keep it ~25 / per day, even it's more ~20 lately)

It's not so much the number of patches per day as the number of test 
units patched.

-- 
Francois Gouget <fgouget at codeweavers.com>



More information about the wine-devel mailing list