[tools] testbot/cgi: Move saving items to ItemPage::Save().
Francois Gouget
fgouget at codeweavers.com
Wed Mar 9 13:13:53 CST 2022
A FormPage has no Collection field and no concept of what an Item
object is so it should not be trying to save items.
Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
testbot/lib/ObjectModel/CGI/FormPage.pm | 5 +----
testbot/lib/ObjectModel/CGI/ItemPage.pm | 10 ++++++++++
2 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/testbot/lib/ObjectModel/CGI/FormPage.pm b/testbot/lib/ObjectModel/CGI/FormPage.pm
index 9ea7f0f5b2..3ac62239d5 100644
--- a/testbot/lib/ObjectModel/CGI/FormPage.pm
+++ b/testbot/lib/ObjectModel/CGI/FormPage.pm
@@ -388,10 +388,7 @@ sub Save($)
{
my ($self) = @_;
- return !1 if (!$self->SaveProperties());
-
- (my $_ErrKey, $self->{ErrField}, $self->{ErrMessage}) = $self->{Collection}->Save();
- return ! defined($self->{ErrMessage});
+ return $self->SaveProperties();
}
sub OnAction($$)
diff --git a/testbot/lib/ObjectModel/CGI/ItemPage.pm b/testbot/lib/ObjectModel/CGI/ItemPage.pm
index 3dab64cf71..940115475f 100644
--- a/testbot/lib/ObjectModel/CGI/ItemPage.pm
+++ b/testbot/lib/ObjectModel/CGI/ItemPage.pm
@@ -134,6 +134,16 @@ sub SaveProperty($$$)
return 1;
}
+sub Save($)
+{
+ my ($self) = @_;
+
+ return !1 if (!$self->SUPER::Save());
+
+ (my $_ErrKey, $self->{ErrField}, $self->{ErrMessage}) = $self->{Collection}->Save();
+ return !defined $self->{ErrMessage};
+}
+
sub OnAction($$)
{
my ($self, $Action) = @_;
--
2.30.2
More information about the wine-devel
mailing list