[RFC PATCH] advapi32/tests: Check the timezone name size limits in all languages.

Alexandre Julliard julliard at winehq.org
Thu Mar 10 16:06:06 CST 2022


Francois Gouget <fgouget at codeweavers.com> writes:

> The localized standard and daylight timezone names returned by
> EnumDynamicTimeZoneInformation() must fit in a 32 character buffer.
> But there is no such limitation in Wine's PO files and the regular
> WineTest runs only cover some locales. So use SetThreadUILanguage() to
> verify the translations in all the known languages.
>
> Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=51619
> Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
> ---
> Unfortunately SetThreadUILanguage() is a stub in Wine so this currently
> has no effect where we need it.
> Also while going through all of Wine's ~150 known languages only takes
> about 35 seconds, this would benefit from some parallelization to
> speed things up (see d3d11:d3d11 for instance). I can send a patch for
> that if this approach is deemed worthwhile.

That seems like a waste of resources for something that can easily be
checked by grepping the po files. We now have a msgctxt that will
hopefully avoid the issue; if it turns out that this is not sufficient,
we can consider adding a compile-time check.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list