[PATCH 1/4] winealsa: Move get_prop_value to the unixlib.

[Huw Davies]

On Tue, Mar 15, 2022 at 09:39:35AM +0000, Emil Velikov wrote:
> On Tue, 15 Mar 2022 at 08:56, Huw Davies <huw at codeweavers.com> wrote:
> >
> > On Tue, Mar 15, 2022 at 08:38:32AM +0000, Emil Velikov wrote:
> > > Have you considered splitting the props handling - get_device_path,
> > > get_physical_speakers?
> > > AFAICT this should reduce the duplication on the unix side (alsa vs
> > > pulse vs others). More importantly it makes it easier to avoid the
> > > caller allocated string, by passing the vendor/device/other data
> > > directly.
> >
> > We could split these, but I didn't want the number of syscalls
> > to escalate.  If there really are only two properties then
> > that doesn't sound too bad.
> >
> Are there any technical implications of having say 10 vs 20 syscalls
> or is it mostly to preserve one's sanity?
> The syscall lookup machinery should not care, unless we're talking
> about orders of magnitude.

No technical reasons, just trying to keep the api sane.

> > Until you'd mentioned it, I'd forgotten about sound side of
> > wineandroid, so I guess that's one more to do :-(
> >
> ^W^W^W^W^W I didn't say anything :-P

It does beg the question of whether wineandroid is still useful
for people.

Huw.