[PATCH 1/4] winemac.drv: Simplify control flow in copy_display_modes.
Huw Davies
huw at codeweavers.com
Tue Mar 22 02:52:29 CDT 2022
On Mon, Mar 21, 2022 at 02:32:20PM -0700, Tim Clem wrote:
> Signed-off-by: Tim Clem <tclem at codeweavers.com>
> ---
> dlls/winemac.drv/display.c | 107 ++++++++++++++++++-------------------
> 1 file changed, 52 insertions(+), 55 deletions(-)
Hi Tim,
I'm not convinced that adding two goto labels is an improvement.
I'd suggest moving the bulk of the code inside the loop to
a helper that returns "better".
Huw.
More information about the wine-devel
mailing list