[PATCH] ntdll: Avoid the lower 2GB region for large allocations on win64.

[Chip Davis]

March 22, 2022 11:38 PM, "Elaine Lefler" <elaineclefler at gmail.com> wrote:

> Got it, will do. Is it better if I resubmit as [PATCH v2 1/2] or
> should the test be submitted as a separate patch?

Generally, todo_wine should be removed in the same patch that fixed the tests.

> 
> On Tue, Mar 22, 2022 at 9:29 PM Chip Davis <cdavis at codeweavers.com> wrote:
> 
>> March 22, 2022 9:39 PM, "Elaine Lefler" <elaineclefler at gmail.com> wrote:
>> 
>> On Tue, Mar 22, 2022 at 8:06 PM Marvin <testbot at winehq.org> wrote:
>> 
>> ntdll:
>> info.c:1843: Test succeeded inside todo block: Expected to be greater than 2045915136, got
>> 2045915136
>> info.c:1860: Test succeeded inside todo block: Expected to be greater than 2045915136, got
>> 2045915136
>> 
>> I assume this is safe to ignore? The code expects "pvi.VirtualSize >=
>> prev_size + alloc_size" and the numbers check out. It doesn't look
>> like anything is wrong.
>> 
>> You're half right--there is nothing wrong with the test itself. But you do need to make a change
>> there.
>> 
>> Not all the tests succeed on Wine. The failing tests are inside statements marked "todo_wine" in
>> the test source--in other words, these tests are "expected to fail" (you may be familiar with the
>> term "XFAIL", as used in GCC, LLVM, and some other projects). Your change makes the tests on those
>> two lines, which are inside a todo_wine block, pass. So you need to remove those tests from the
>> todo_wine block.
>> 
>> Chip


Chip