[PATCH 1/3] macdrv: Add wintab32 implementation.

[Elaine Lefler]

On Wed, Mar 23, 2022 at 3:42 AM Huw Davies <huw at codeweavers.com> wrote:
> Hi Elaine,
>
> Thanks for the patches.  Unfortunately at the moment this patch is too
> large to review properly.  Could you try breaking it down into several
> smaller, self-contained patches?
>
> Huw.

Hi Huw,

I can try. Unfortunately these changes are very co-dependent, so it's
difficult to break them up in any logical way.

If you're okay with reviewing patches that aren't meaningful on their
own, I could split it into the following:
1) Move/rename wintab definitions to reduce code duplication (large
patch, but it's just a trivial refactor)
2) Correct wintab32.dll behavior (smaller patch)
3) Add macdrv wintab implementation (still around 1000 lines, there's
absolutely nothing I can do about this)

Does that work for you? I certainly understand your hesitance to
review a large patch from a new developer. Since it's a brand new
driver the majority of the code is "all or nothing" because an
incomplete implementation doesn't work at all. Best I can do is to
separate the new code from the refactors. If you're okay with the
above plan, I'll resubmit tomorrow.

Thanks,
- Elaine