[tools] testbot/web: Provide a property list for the special jobs page.
Francois Gouget
fgouget at codeweavers.com
Fri Mar 25 05:21:56 CDT 2022
The property descriptors list can be empty, but it must not be left
undefined forever.
Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
The patch reordering the FormPage methods contained a change it
shouldn't have which broke the special jobs page. At least that's much
less of an issue than breaking the submit page (see previous patch).
It would probably be even better to provide a list of
EnumPropertyDescriptor()s instead of having the page roll its own. But
then this page should be rewritten to use checkboxes similar to the ones
of the Submit page. Which also means this type of VM selection code
should be shared. And further extended to allow choosing between 32- and
64-bit for each VM. That will all have to wait though.
---
testbot/web/admin/SpecialJobs.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/testbot/web/admin/SpecialJobs.pl b/testbot/web/admin/SpecialJobs.pl
index 02d9f8ea9..79160e42f 100644
--- a/testbot/web/admin/SpecialJobs.pl
+++ b/testbot/web/admin/SpecialJobs.pl
@@ -90,7 +90,7 @@ sub _initialize($$$)
$JobTemplate->{VMKey} ||= "*No";
}
- $self->SUPER::_initialize($Request, $RequiredRole, undef);
+ $self->SUPER::_initialize($Request, $RequiredRole, []);
}
--
2.30.2
More information about the wine-devel
mailing list