[PATCH 3/3] programs/cmd: implement filename completion

Eric Pouech eric.pouech at orange.fr
Fri Mar 25 10:54:20 CDT 2022


> I think that last1 should use wcsrchr as well? Or maybe even replace 
> the whole dirlen logic with a simple loop.

the idea is to find the last '/' or '\\'... so if '/' if r-found, we try 
to find forward a '\\'... so the

but wcsrpbrk doesn't exist AFAICT...
but supporting here unix paths might be a bit overkill; so we could keep only the first wcsrchr(..., '\\')

>
> If I read it correctly, if another process creates a file when 
> completion is already initialized, we will not take that into account. 
> Is that intended?
>
well, that's the way it's coded <g>, and the way it's implemented on 
native (tested with W11)

ditto if a file is deleted


A+






More information about the wine-devel mailing list