[tools] testbot/cgi: Remove the PageBase::SetCurrentSession() $Page parameter.

Francois Gouget fgouget at codeweavers.com
Mon Mar 28 10:29:12 CDT 2022


It is unused and there is no indication it may be needed one day.
With that change none of the 'session management' methods take a $Page
parameter.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
 testbot/lib/ObjectModel/CGI/Page.pm     | 2 +-
 testbot/lib/WineTestBot/CGI/PageBase.pm | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/testbot/lib/ObjectModel/CGI/Page.pm b/testbot/lib/ObjectModel/CGI/Page.pm
index 014324f60..d5874129a 100644
--- a/testbot/lib/ObjectModel/CGI/Page.pm
+++ b/testbot/lib/ObjectModel/CGI/Page.pm
@@ -241,7 +241,7 @@ sub SetCurrentSession($$)
 {
   my ($self, $Session) = @_;
 
-  $self->{PageBase}->SetCurrentSession($self, $Session);
+  $self->{PageBase}->SetCurrentSession($Session);
 }
 
 sub Redirect($$)
diff --git a/testbot/lib/WineTestBot/CGI/PageBase.pm b/testbot/lib/WineTestBot/CGI/PageBase.pm
index aa90245cf..6eba0e0eb 100644
--- a/testbot/lib/WineTestBot/CGI/PageBase.pm
+++ b/testbot/lib/WineTestBot/CGI/PageBase.pm
@@ -224,9 +224,9 @@ sub GetCurrentSession($)
   return $self->{Session};
 }
 
-sub SetCurrentSession($$$)
+sub SetCurrentSession($$)
 {
-  my ($self, $Page, $Session) = @_;
+  my ($self, $Session) = @_;
 
   $self->{Session} = $Session;
   if (! defined($Session))
-- 
2.30.2



More information about the wine-devel mailing list