[PATCH 2/2] wdscore: Add CurrentIP stub.
Mohamad Al-Jaf
mohamadaljaf at gmail.com
Wed Mar 30 02:39:51 CDT 2022
Hi Alex,
On Tue, Mar 29, 2022 at 3:00 AM Alex Henrie <alexhenrie24 at gmail.com> wrote:
> I've been meaning to look at this for a while and finally did it
> today. The first half of the original section (the half that explains
> the stdcall calling convention) was helpful to me, and what's even
> more helpful is the example code that you posted earlier in this
> thread. Consequently, I have restored the first half and added an
> example based on your code, as well as an explicit warning against
> disassembly:
>
> https://wiki.winehq.org/Wine_Developer%27s_Guide/Other_Debugging_Techniques
Thanks for adding that section, it looks great.
> Please let me know if you think that more changes are necessary.
I'd also add in Zebediah's suggestion if one cannot reasonably guess their type:
> If you can't tell I'd recommend using "void *" or
> "DWORD_PTR" so that the entire value is captured.
--
Kind regards,
Mohamad
More information about the wine-devel
mailing list