[PATCH] testbot/TestLauncher: Create processes with DETACHED_PROCESS flag.

Rémi Bernon rbernon at codeweavers.com
Wed Mar 30 08:15:17 CDT 2022


So that it doesn't automatically create a console window when there is
not one already.

Fixing a Wine regression from f034084d49b354811096524d472ae5172ac1cebf.

Signed-off-by: Rémi Bernon <rbernon at codeweavers.com>
---

I'm not completely sure what DETACHED_PROCESS implies, and hopefully
this won't cause more trouble, but forcing the flag like in
https://testbot.winehq.org/JobDetails.pl?Key=111584 seems to fix the
regression.

 testbot/src/TestLauncher/TestLauncher.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testbot/src/TestLauncher/TestLauncher.c b/testbot/src/TestLauncher/TestLauncher.c
index 41fb904..17da4da 100644
--- a/testbot/src/TestLauncher/TestLauncher.c
+++ b/testbot/src/TestLauncher/TestLauncher.c
@@ -236,7 +236,7 @@ DWORD RunTest(char *TestExeFileName, char* CommandLine, DWORD TimeOut, DWORD *Pi
     * whether there are missing dependencies as it could modify the test
     * results...
     */
-   if (! CreateProcessA(NULL, CommandLine, NULL, NULL, TRUE, CREATE_DEFAULT_ERROR_MODE, NULL, NULL, &StartupInfo, &ProcessInformation))
+   if (! CreateProcessA(NULL, CommandLine, NULL, NULL, TRUE, CREATE_DEFAULT_ERROR_MODE|DETACHED_PROCESS, NULL, NULL, &StartupInfo, &ProcessInformation))
    {
       *Pid = 0;
       if (GetLastError() == ERROR_SXS_CANT_GEN_ACTCTX)
-- 
2.35.1




More information about the wine-devel mailing list