[PATCH 1/5] windows.media.speech: Add IVector<Inspectable*>.

Rémi Bernon rbernon at codeweavers.com
Wed Mar 30 11:10:34 CDT 2022


On 3/30/22 18:08, Bernhard Kölbl wrote:
> I think I added these for style reasons, but I can also just let free
> check for null pointers.
> 
> Bernhard
> 
> Am Mi., 30. März 2022 um 17:43 Uhr schrieb Rémi Bernon
> <rbernon at codeweavers.com>:
>>
>> On 3/30/22 15:15, Bernhard Kölbl wrote:
>>> +
>>> +error:
>>> +    if (session) free(session);
>>> +    if (impl) free(impl);
>>> +
>> You don't need the if before free. FWIW I've missed it before but I
>> think there's another one else where that you could remove at some point
>> later.
>>
>> --
>> Rémi Bernon <rbernon at codeweavers.com>
>>

Yeah I think we usually do that, it removes a conditional and simplifies 
the code.
-- 
Rémi Bernon <rbernon at codeweavers.com>



More information about the wine-devel mailing list