MR23v1 - shell32: Sanitize Program Manager icon and group names
Alexandre Julliard (@julliard)
wine at gitlab.winehq.org
Tue May 3 03:22:56 CDT 2022
Alexandre Julliard (@julliard) commented about dlls/shell32/dde.c:
> WCHAR *groups_data = heap_alloc(sizeof(WCHAR));
> char *groups_dataA;
> HDDEDATA ret;
> + static WCHAR star[] = L"*";
>
> groups_data[0] = 0;
> - programs = get_programs_path(L"*");
> + programs = get_programs_path(star, FALSE);
It's ugly to have to pass a non-const buffer that actually won't get modified. You should rethink your helper functions.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/23#note_550
More information about the wine-devel
mailing list