[PATCH 2/9] dinput/tests: Do not test that reports are identical when polling.

Zebediah Figura wine at gitlab.winehq.org
Tue May 3 04:20:44 CDT 2022


From: Zebediah Figura <zfigura at codeweavers.com>

This is dependent on timing, and currently fails occasionally both on Windows
and Wine.

Signed-off-by: Zebediah Figura <zfigura at codeweavers.com>
Signed-off-by: Rémi Bernon <rbernon at codeweavers.com>
---
 dlls/dinput/tests/hid.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/dlls/dinput/tests/hid.c b/dlls/dinput/tests/hid.c
index 4e107625064..aeafbd4dbc3 100644
--- a/dlls/dinput/tests/hid.c
+++ b/dlls/dinput/tests/hid.c
@@ -2343,12 +2343,11 @@ static void test_hidp( HANDLE file, HANDLE async_file, int report_id, BOOL polle
         ok( ret, "GetOverlappedResult failed, last error %lu\n", GetLastError() );
         ok( value == (report_id ? 3 : 4), "GetOverlappedResult returned length %lu, expected %u\n",
             value, (report_id ? 3 : 4) );
-        /* first report should be ready and the same */
+        /* first report should be ready */
         ret = GetOverlappedResult( async_file, &overlapped, &value, FALSE );
         ok( ret, "GetOverlappedResult failed, last error %lu\n", GetLastError() );
         ok( value == (report_id ? 3 : 4), "GetOverlappedResult returned length %lu, expected %u\n",
             value, (report_id ? 3 : 4) );
-        ok( !memcmp( report, buffer, caps.InputReportByteLength ), "expected identical reports\n" );
 
         send_hid_input( file, expect_small, sizeof(expect_small) );
 
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/26



More information about the wine-devel mailing list