MR23v2 - shell32: Sanitize Program Manager icon and group names

Alex Henrie (@alexhenrie) wine at gitlab.winehq.org
Tue May 3 23:56:00 CDT 2022


On Wed May  4 04:54:51 2022 +0000, Alex Henrie wrote:
> changed this line in [version 2 of the diff](/wine/wine/-/merge_requests/23/diffs?diff_id=462&start_sha=454614a6a842a5c765bf107862ae97e36e765053#5e9b272a4b8973d33b8b2698e9f973594d3740c0_145_146)
Thanks for the feedback. I have added a call to strdupW to the sanitize_and_combine function so that the name arguments of both helpers can be const. The only other option I see is to duplicate the get_programs_path function to make a separate get_sanitized_programs_path. Please let me know if you would prefer that, or if you see a third option.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/23#note_587



More information about the wine-devel mailing list