[PATCH 2/9] wined3d: Prepare wined3d_format_convert_from_float for > 32bpp formats.

Stefan Dösinger stefandoesinger at gmail.com
Thu May 5 08:23:36 CDT 2022


Am Montag, 2. Mai 2022, 18:36:25 EAT schrieb Henri Verbeet:
> This patch always writes 4  uint32_t's in
> wined3d_format_convert_from_float(), but that could easily be avoided.

I made it write 16 bytes unconditionally on purpose - I don't like the idea of 
the caller magically knowing which format requires how many output bytes. I am 
not married to that though, since in practise the caller has to put the 
returned result somewhere anyhow.

In practise writing format->byte_count would do, as long as we don't add 
support for block based formats. I am not sure it would really make things 
nicer though.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20220505/bcedcdbe/attachment.sig>


More information about the wine-devel mailing list