[PATCH 2/2] evr/sample: Use explicit critical section for release handling.

Nikolay Sivov nsivov at codeweavers.com
Tue May 10 11:16:18 CDT 2022


Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
---

Locking methods were used here before critical section was introduced,
no reason to use them now.

 dlls/evr/sample.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/evr/sample.c b/dlls/evr/sample.c
index 738f803fe66..3521e6c4d51 100644
--- a/dlls/evr/sample.c
+++ b/dlls/evr/sample.c
@@ -923,7 +923,7 @@ static ULONG WINAPI video_sample_Release(IMFSample *iface)
     ULONG refcount = InterlockedDecrement(&sample->refcount);
     IMFAsyncResult *tracked_result = NULL;
 
-    IMFSample_LockStore(sample->sample);
+    EnterCriticalSection(&sample->cs);
     if (sample->tracked_result && sample->tracked_refcount == refcount)
     {
         tracked_result = sample->tracked_result;
@@ -931,7 +931,7 @@ static ULONG WINAPI video_sample_Release(IMFSample *iface)
         sample->tracked_result = NULL;
         sample->tracked_refcount = 0;
     }
-    IMFSample_UnlockStore(sample->sample);
+    LeaveCriticalSection(&sample->cs);
 
     if (tracked_result)
         IMFAsyncResult_Release(tracked_result);
-- 
2.35.1




More information about the wine-devel mailing list