Envisioned Gitlab workflow
Alexandre Julliard
julliard at winehq.org
Wed May 11 04:14:02 CDT 2022
Charles Davis <cdavis5x at gmail.com> writes:
> On Mon, Apr 25, 2022 at 12:04 PM Alexandre Julliard <julliard at winehq.org> wrote:
>> 1. All patch series are submitted as Merge Requests, so that the
>> proper information can be captured. The usual rules apply (small
>> patches, small number of patches per MR, sign-off by submitter).
>>
>> There are various methods available for creating merge requests:
>> - using the web interface
>> - directly when pushing: git push -o merge_request.create
>> cf. https://docs.gitlab.com/ee/user/project/push_options.html
>> - from the command line, eg. 'glab mr create'
>> cf. https://glab.readthedocs.io/en/latest/mr/create.html
>> - by email
>> cf. https://docs.gitlab.com/ee/user/project/merge_requests/creating_merge_requests.html
>
> I take it, then, that MRs should have changes to generated files (e.g.
> autoconf scripts) in them?
> I know the long-standing policy of this project was that patches
> *shouldn't* include generated files
> in them, because you would regenerate the files when you committed the patches.
I'm doing it the same way for merge requests, so generated files don't
need to be included either.
--
Alexandre Julliard
julliard at winehq.org
More information about the wine-devel
mailing list