[PATCH] shell32/tests: Fix FO_MOVE test when dest directory doesn't exist

Nipun Garg nipung271 at gmail.com
Tue May 17 03:59:57 CDT 2022


Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=38379
Signed-off-by: Nipun Garg <nipung271 at gmail.com>
---
 dlls/shell32/tests/shlfileop.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/dlls/shell32/tests/shlfileop.c b/dlls/shell32/tests/shlfileop.c
index 273b09d5005..839254278e9 100644
--- a/dlls/shell32/tests/shlfileop.c
+++ b/dlls/shell32/tests/shlfileop.c
@@ -2306,14 +2306,15 @@ static void test_move(void)
         ok(!DeleteFileA("d.txt"), "Expected d.txt to not exist\n");
     }
 
-    /* FO_MOVE does not create dest directories */
+    /* FO_MOVE does create dest directories */
     shfo.pFrom = "test2.txt\0";
     shfo.pTo = "dir1\\dir2\\test2.txt\0";
     retval = SHFileOperationA(&shfo);
+    todo_wine {
+        ok(retval == ERROR_SUCCESS || broken(retval == ERROR_CANCELLED) || broken(DE_OPCANCELLED), "Expected ERROR_SUCCESS, got %ld\n", retval);
+    }
     if (dir_exists("dir1"))
     {
-        /* Vista and W2K8 (broken or new behavior ?) */
-        ok(retval == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %ld\n", retval);
         ok(DeleteFileA("dir1\\dir2\\test2.txt"), "Expected dir1\\dir2\\test2.txt to exist\n");
         RemoveDirectoryA("dir1\\dir2");
         RemoveDirectoryA("dir1");
-- 
2.25.1




More information about the wine-devel mailing list