[PATCH 4/4] windows.gaming.input: Ignore IDirectInputDevice8_GetDeviceState failures.

Rémi Bernon wine at gitlab.winehq.org
Thu May 19 02:42:51 CDT 2022


From: Rémi Bernon <rbernon at codeweavers.com>

We will get hotplug notifications asynchronously, and returning an error
here can cause uncaught C++ exceptions in games.

Signed-off-by: Rémi Bernon <rbernon at codeweavers.com>
---
 dlls/windows.gaming.input/provider.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/windows.gaming.input/provider.c b/dlls/windows.gaming.input/provider.c
index 1f3f4e047f5..39229a35c7d 100644
--- a/dlls/windows.gaming.input/provider.c
+++ b/dlls/windows.gaming.input/provider.c
@@ -212,7 +212,7 @@ static HRESULT WINAPI wine_provider_get_State( IWineGameControllerProvider *ifac
     if (FAILED(hr = IDirectInputDevice8_GetDeviceState( impl->dinput_device, sizeof(state), &state )))
     {
         WARN( "Failed to read device state, hr %#lx\n", hr );
-        return hr;
+        return S_OK;
     }
 
     i = ARRAY_SIZE(state.rgbButtons);
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/94



More information about the wine-devel mailing list