[PATCH 0/4] MR98: Some registry access fixes

Torge Matthies (@tmatthies) wine at gitlab.winehq.org
Thu May 19 14:07:05 CDT 2022


I had these in my patch repo for quite a while.

Patch 1 shouldn't need explanation.

The problem fixed by patch 2 and 3 is that
sizeof(KEY_{BASIC,VALUE_PARTIAL,FULL}_INFORMATION) are all slightly bigger
than the actual minimum size required to get all the requested info, because
those structs include an array of size 1 as their last member, which is
intended to be a variable length array.
Fixing these size calculations removes one allocation in wineserver and
reduces the amount of data transmitted by 1 - 2 bytes.

Patch 4 just reduces the amount of data transmitted from wineserver for each
update_display_cache_from_registry call, which is called every time the
display device lists are locked.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/98



More information about the wine-devel mailing list