winegstream reintroduce parser flushing

[Bernhard Kölbl]

Am Fr., 20. Mai 2022 um 15:54 Uhr schrieb Zlice Z <zlice555 at gmail.com>:
>
> I think I did the patch right this time? Not really fluent with git.
>
It's still missing your full name in the "from" line, according to:
https://wiki.winehq.org/Submitting_Patches#Check_your_Git_setup

> I see the part about needing to be subscribed to the mailing list.
> Can I unsub immediately after?
>
You probably should stay subscribed for the time your patch will be reviewed.

> Can send directly to wine-devel again with the patch subject if this looks good.
>
Sure, and it's probably best to set the E-Mail subject to the commit
message. Just look how other patches are submitted.

Thanks,
Bernhard

> Thanks
>
> On Fri, May 20, 2022 at 9:21 AM Bernhard Kölbl <besentv at gmail.com> wrote:
>>
>> This still doesn't meet the requirements for how a patch needs to look like.
>> Please check the link I sent, again and rework the patch and mail
>> accordingly: i.e. Correct commit message, correct patch format, etc.
>>
>> Thanks,
>> Bernhard
>>
>> Am Fr., 20. Mai 2022 um 14:34 Uhr schrieb Zlice Z <zlice555 at gmail.com>:
>> >
>> > Removed commented blocks, added more verbose comments.
>> >
>> > On Fri, May 20, 2022 at 3:46 AM Bernhard Kölbl <besentv at gmail.com> wrote:
>> >>
>> >> Hi Zlice,
>> >>
>> >> thanks for your patch. Unfortunately you're missing out on quite a few requirements for this to get accepted. I'd recommend to refactor your submission using this guide as reference: https://wiki.winehq.org/Submitting_Patches and to resend it afterwards.
>> >>
>> >> E.g. you left in C++ comments, which aren't allowed.
>> >>
>> >> Thanks,
>> >> Bernhard
>> >>
>> >>
>> >> Zlice Z <zlice555 at gmail.com> schrieb am Fr., 20. Mai 2022, 09:22:
>> >>>
>> >>> Sent a patch yesterday that was mediocre and barely helps.
>> >>>
>> >>> commit https://github.com/wine-mirror/wine/commit/5144b27661fcd6705353d832e0383085f8afe842#
>> >>>
>> >>> removed flushing from parser, which after commit bisecting turns out to be the cause of Fallout 3 radio chugging every new song.
>> >>>
>> >>> - re-introduced parser flushing (self explanatory, commit said it's not worth it but it helps here)
>> >>>
>> >>> - moved some variable initialization in wm_reader.c to after initial conditional returns. these were in a switch-case before in the middle of the function and it seems to be part of the stuttering, wasn't moved in the mentioned commit though
>> >>>
>> >>> - commented out and left my name by some EOS sets. they used to be checked for EOS 'events' but those references have been changed to 'buffer' and idk what the right action is. wine seemed to randomly seg fault on exit with leaving them on though. suspect they incorrectly guess and set 'end of stream' ?