[PATCH v4 0/10] MR79: wined3d: Refactor format flags into two groups.

[Chip Davis (@cdavis5e)]

On Fri May 20 17:13:12 2022 +0000, **** wrote:
> Zebediah Figura replied on the mailing list:
> ```
> On 5/20/22 04:06, Jan Sikorski (@jsikorski) wrote:
> > On Fri May 20 09:06:20 2022 +0000, Chip Davis wrote:
> >> @jsikorski, I have no way of verifying that I didn't break the tests on
> >> Vulkan again. They crash on me at this moment.
> > I get the same result. Do you get a crash in test_texture() and
> test_compressed_format_compatibility() specifically? Those are the ones
> that regress.
> > 
> I'm getting the same errors with GL too, actually. They seem to be 
> triggered by patch 6/10 (the one moving BLOCKS etc.)
> ```
> I get the same result. Do you get a crash in test_texture() and test_compressed_format_compatibility() specifically? Those are the ones that regress.

I don't see those failures. With Vulkan, I see different crashes that have a lot to do with a) MoltenVK not implementing stuff that b) wined3d blindly assumes that a Vulkan implementation will have. I see crashes in `test_so_statistics_query()` and `test_clear_state()`. With OpenGL, it doesn't even actually run any tests.

This is supposed to be NFC. I don't see anything in the patch itself that would cause problems, yet clearly something is lurking there. Exactly what failures do you see?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/79#note_1088