[PATCH 0/5] MR116: qasf: Better implementation of ASF reader filter.

[Rémi Bernon (@rbernon)]

On Tue May 24 06:14:02 2022 +0000, Rémi Bernon wrote:
> > InterlockedOr() looks suspicious. If we're going to be thread safe
> (and 
> > we should) we should just take the filter lock around 
> > IFileSourceFilter::Load(). [It's already implicitly taken in the 
> > get_pin() callback.]
> I was wary of locking because WM reader callbacks are done while holding
> WM reader lock, and prevent any concurrent call to other WM reader
> methods. I had some patches to leave the lock when calling the callbacks
> but I'm not sure it's a good way to go.
> [It's already implicitly taken in the get_pin() callback.]

Is it really? I don't see it anywhere and it looks to me that `filter->ops->filter_get_pin` is called in many places unguarded, like `enum_pins_Clone`, `enum_pins_Next`, `filter_EnumPins`, etc...

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/116#note_1142