[PATCH 0/6] MR118: windows.media.speech: IAsyncAction implementation.

Rémi Bernon (@rbernon) wine at gitlab.winehq.org
Tue May 24 09:25:43 CDT 2022


Rémi Bernon (@rbernon) commented about dlls/windows.media.speech/async.c:
> +
> +    return hr;
>  }
>  
>  HRESULT WINAPI async_void_get_Completed( IAsyncAction *iface, IAsyncActionCompletedHandler **handler )
>  {
> -    FIXME("iface %p, handler %p stub!\n", iface, handler);
> -    return E_NOTIMPL;
> +    struct async_void *impl = impl_from_IAsyncAction(iface);
> +    HRESULT hr = S_OK;
> +
> +    FIXME("iface %p, handler %p semi stub!\n", iface, handler);
> +
> +    if (impl->status == Closed)
> +        hr = E_ILLEGAL_METHOD_CALL;
> +    *handler = (impl->handler != HANDLER_NOT_SET) ? impl->handler : NULL;
This will need to be fixed in the `async_inspectable` too but you need to `AddRef` on the returned handler if it's not `NULL`.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/118#note_1147



More information about the wine-devel mailing list