[PATCH 0/2] MR127: ws2_32: Make wait in select alertable

[Jinoh Kang]

On 5/26/22 00:46, Jinoh Kang wrote:
> On 5/25/22 22:30, Alexandre Julliard wrote:
>>> We can wrap the IOSB writes in `set_async_iosb` inside a `__TRY` block from `wine/unixlib.h`.
>>
>> That would only be hiding the bug.
>>
> 
> Handling the exception does not necessarily mean silencing the bug; we can flag the error condition via ERR().
> Also, letting the IOSB leak won't make debugging much more pleasurable either IMHO:
> 
> 1. There's no way to detect pulling the rug out under a pending I/O operation.
> 2. It causes hard-to-trace memory leak.

On a second thought, we *can* use IO_APC_ROUTINE to detect leaked IOSB on completion (and maybe free it).

Maybe it's not worth it, but I think it would still be nice to have some way (not necessarily mine) to detect when the app exhibits such abominable behavior, perhaps too frequently...


-- 
Sincerely,
Jinoh Kang