[PATCH 0/6] MR130: user32: Progress toward PE conversion of raw input APIs.

Rémi Bernon (@rbernon) wine at gitlab.winehq.org
Thu May 26 08:33:52 CDT 2022


Rémi Bernon (@rbernon) commented about dlls/user32/rawinput.c:
> +
> +        case RIM_TYPEMOUSE:
> +        {
> +            static const RID_DEVICE_INFO_MOUSE mouse_info = {1, 5, 0, FALSE};
> +
> +            info.mouse = mouse_info;
> +            break;
> +        }
> +
> +        case RIM_TYPEKEYBOARD:
> +        {
> +            static const RID_DEVICE_INFO_KEYBOARD keyboard_info = {0, 0, 1, 12, 3, 101};
> +
> +            info.keyboard = keyboard_info;
> +            break;
> +        }
You're missing the sign-off on some of the commits.

I also think that it'd be best to take that occasion to make the style used in this file more consistent with the rest of the module (and the file), so not indenting case statements. More of a nitpick, the mouse and keyboard cases could waste less vertical space with static declarations on top and single line cases.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/130#note_1237



More information about the wine-devel mailing list